STCOM-1385 Clear filter value after an action is chosen from MultiSelection #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Code changes LGTM. Is it possible to capture this behavior in a new test, e.g. to assert that the filter is empty after one of thes events on lines 263/264/265 fires?
Unrelated, I'm not usually a fan of "while you're in there..." changes, but is it maybe worth fixing the comment on line 276/277? That hardly feels worth it's own PR, but it's definitely wrong.
OleksandrHladchenko1
approved these changes
Nov 20, 2024
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…ection (#2393) * clear filter value after an action is chosen from MultiSelection's option list. * add tests for removed filter value, updated comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STCOM-1385
Known locations affected: Tags (linked in main JIRA), Agreements->Settings ->Supplementary properties (closed as duplicate)
Approach
Multiselection needs to reset the filter value when an option's
onSelecthandler is called (actions API for Multiselection) Otherwise, the filter value will not be reset as it usually is through typical value selection logic.